Skip to content

Expose profile arg from renv::activate()#649

Merged
gaborcsardi merged 6 commits intor-lib:v2-branchfrom
Bisaloo:renv-profile
Oct 26, 2022
Merged

Expose profile arg from renv::activate()#649
gaborcsardi merged 6 commits intor-lib:v2-branchfrom
Bisaloo:renv-profile

Conversation

@Bisaloo
Copy link
Copy Markdown
Contributor

@Bisaloo Bisaloo commented Oct 24, 2022

Tested here.

Fix #648

Copy link
Copy Markdown
Member

@gaborcsardi gaborcsardi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good, added some questions.

Co-authored-by: Indrajeet Patil <patilindrajeet.science@gmail.com>
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Oct 25, 2022

Codecov Report

Merging #649 (dc86230) into v2-branch (20ffd99) will not change coverage.
The diff coverage is n/a.

❗ Current head dc86230 differs from pull request most recent head 8cdc630. Consider uploading reports for the commit 8cdc630 to get more accurate results

@@             Coverage Diff             @@
##           v2-branch      #649   +/-   ##
===========================================
  Coverage     100.00%   100.00%           
===========================================
  Files              2         2           
  Lines             10        10           
===========================================
  Hits              10        10           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@gaborcsardi gaborcsardi merged commit 990b4e1 into r-lib:v2-branch Oct 26, 2022
@gaborcsardi
Copy link
Copy Markdown
Member

Thank you!

@Bisaloo Bisaloo deleted the renv-profile branch October 26, 2022 09:01
@github-actions
Copy link
Copy Markdown

This pull request has been automatically locked. If you believe you have found a related problem, please file a new issue and include a link to this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Expose profile argument in setup-renv

4 participants