Skip to content

Add check-hard.yaml example to mimic noSuggests#549

Merged
gaborcsardi merged 2 commits intor-lib:v2-branchfrom
DavisVaughan:feature/no-suggests
Oct 19, 2022
Merged

Add check-hard.yaml example to mimic noSuggests#549
gaborcsardi merged 2 commits intor-lib:v2-branchfrom
DavisVaughan:feature/no-suggests

Conversation

@DavisVaughan
Copy link
Copy Markdown
Member

@DavisVaughan DavisVaughan commented Apr 7, 2022 •
edited
Loading

Closes #548

@gaborcsardi feel free to take over from here if you'd like to change anything. I've left it as a build matrix even though only 1 flavor is being used because I feel like there may be cases where we want to add some other flavor to the build. Otherwise it could look more like check-release.yaml if we wanted to simplify the matrix.

@DavisVaughan
Copy link
Copy Markdown
Member Author

DavisVaughan commented Apr 8, 2022

Max has requested a name more like check-no-suggests.yaml. I don't have strong feelings either way

@gaborcsardi
Copy link
Copy Markdown
Member

gaborcsardi commented Oct 19, 2022 •
edited
Loading

I am going to merge this now as is after renaming it, but we might move "contributed" workflows to a different location in the future, to a different directory or repository, mainly to make it clear that they are not regularly tested.

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Oct 19, 2022

Codecov Report

Merging #549 (236ce20) into v2-branch (58a65c1) will not change coverage.
The diff coverage is n/a.

❗ Current head 236ce20 differs from pull request most recent head 06c390c. Consider uploading reports for the commit 06c390c to get more accurate results

@@             Coverage Diff             @@
##           v2-branch      #549   +/-   ##
===========================================
  Coverage     100.00%   100.00%           
===========================================
  Files              2         2           
  Lines             10        10           
===========================================
  Hits              10        10

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@gaborcsardi
Copy link
Copy Markdown
Member

gaborcsardi commented Oct 19, 2022

Thanks a lot!

@gaborcsardi gaborcsardi merged commit 3d12e95 into r-lib:v2-branch Oct 19, 2022
@github-actions
Copy link
Copy Markdown

github-actions bot commented Nov 4, 2022

This pull request has been automatically locked. If you believe you have found a related problem, please file a new issue and include a link to this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 4, 2022
@DavisVaughan DavisVaughan deleted the feature/no-suggests branch October 21, 2024 19:35
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Notes on a noSuggests-like workflow

3 participants

@DavisVaughan @gaborcsardi @codecov-commenter