Merged
Conversation
nulano
reviewed
Mar 6, 2021
src/PIL/Image.py
Outdated
| if self.mode in ("LA", "RGBA"): | ||
| return ( | ||
| self.convert("La") | ||
| self.convert(self.mode.replace("A", "a")) |
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Member
|
I don't like this, while it does remove a duplicated bit of code, it obscures what's happening. In my opinion,
If really want to do something to remove the duplicate code, perhaps a dict with a mapping of |
Member
Author
|
I've pushed a commit to use the mapping option, and in two other locations as well. |
hugovk
approved these changes
Jun 28, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I think this change simplifies the code. Feel free to disagree.