Merged
Conversation
srittau
approved these changes
Aug 15, 2022
Collaborator
srittau
left a comment
There was a problem hiding this comment.
LGTM, except for the minor flake8 error, but I'd like @hauntsaninja's feedback.
hauntsaninja
approved these changes
Aug 20, 2022
Collaborator
hauntsaninja
left a comment
There was a problem hiding this comment.
Thanks, this looks good to me, just had one nit about testing
|
|
||
|
|
||
| class AnyTests(BaseTestCase): | ||
| class SubclassesAny(Any): |
Collaborator
There was a problem hiding this comment.
Let's put this into an actual test case?
Wouldn't hurt to copy over the tests from test_can_subclass in the original PR; I seem to recall there was some trickiness wrt inheritance, so might as well test it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport from 3.11+ version (also with fix from python/cpython#95987)