Skip to content

Fix linting#875

Merged
srittau merged 4 commits intopython:masterfrom
srittau:fix-linting
Aug 30, 2021
Merged

Fix linting#875
srittau merged 4 commits intopython:masterfrom
srittau:fix-linting

Conversation

@srittau
Copy link
Copy Markdown
Collaborator

@srittau srittau commented Aug 30, 2021

  • Split linting against implementation and tests into two steps.
  • Add more error codes for test linting.
  • Lint with Python 3.9.
  • Fix a linting problem.

Ideally, we'd have just one configuration for linting both the implementation and tests.

@srittau srittau changed the title Split linting into two steps Fix linting Aug 30, 2021
@srittau srittau marked this pull request as ready for review August 30, 2021 21:44
@JelleZijlstra
Copy link
Copy Markdown
Member

There's another 3.10 CI issue, one that I didn't see locally.

@srittau
Copy link
Copy Markdown
Collaborator Author

srittau commented Aug 30, 2021

If I understand correctly, this is not really a 3.10 problem, but a CI problem. CI shouldn't run the typing tests for 3.10, only the typing_extension tests. Working on it.

@srittau srittau merged commit 68e7cb7 into python:master Aug 30, 2021
@srittau srittau deleted the fix-linting branch August 30, 2021 22:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants