Skip to content

Add a missing comma to __all__#808

Merged
JelleZijlstra merged 2 commits intopython:masterfrom
BvB93:__all__
May 4, 2021
Merged

Add a missing comma to __all__#808
JelleZijlstra merged 2 commits intopython:masterfrom
BvB93:__all__

Conversation

@BvB93
Copy link
Copy Markdown
Contributor

@BvB93 BvB93 commented May 4, 2021

A comma is currently missing between "DefaultDict" and "OrderedDict",
thus concatenating both names into the non-existent "DefaultDictOrderedDict".

Copy link
Copy Markdown
Collaborator

@hauntsaninja hauntsaninja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Maybe worth a patch release? cc @JelleZijlstra

@JelleZijlstra
Copy link
Copy Markdown
Member

Well that's embarrassing. I'm hoping we'll also get Required/NotRequired in soon, so let's give it a few more days for a release.

@JelleZijlstra JelleZijlstra merged commit c4191ac into python:master May 4, 2021
@BvB93 BvB93 deleted the __all__ branch May 4, 2021 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants