[mypyc] Fix glue methods with native int types#13939
Merged
Conversation
ilevkivskyi
approved these changes
Oct 25, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes handling of bitmap arguments used to track default values of arguments with native int types in method overrides.
The main use case is a method override that adds a native int argument with a default value to the base class signature.
Also generate an error if we don't support generating a glue method for an override. This can happen if the positions of bits in the bitmap would change in the subclass. We also don't support switching between error values and default value bitmaps in glue methods. These could be supported, but it would be complicated and doesn't seem worth it.
Work on mypyc/mypyc#837.