make_simplified_union: simpler and faster#12630
Merged
JukkaL merged 2 commits intopython:masterfrom Apr 20, 2022
Merged
Conversation
Recent attempts at speedup introduced some convoluted logic that both reduced accuracy and caused performance regressions. Fix this and add more comments to clarify the reasoning behind the optimization.
This comment has been minimized.
This comment has been minimized.
Collaborator
hauntsaninja
left a comment
There was a problem hiding this comment.
Thanks, looks good to me, this is a nice change.
I think is_likely_literal_supertype should be unused now — could you remove it?
Contributor
Author
done |
Contributor
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
hauntsaninja
approved these changes
Apr 20, 2022
Collaborator
|
Thanks! This is much cleaner than what we had before. |
JukkaL
pushed a commit
that referenced
this pull request
Apr 20, 2022
Recent attempts at speedup introduced some convoluted logic that both reduced accuracy and caused performance regressions. Fix this and add more comments to clarify the reasoning behind the optimization.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Recent attempts at speedup introduced some convoluted logic that both
reduced accuracy and caused performance regressions. Fix this and add
more comments to clarify the reasoning behind the optimization.