stubgen: Fix non default keyword-only argument positioning (#11082)#12303
Merged
hauntsaninja merged 1 commit intopython:masterfrom Mar 8, 2022
Merged
stubgen: Fix non default keyword-only argument positioning (#11082)#12303hauntsaninja merged 1 commit intopython:masterfrom
hauntsaninja merged 1 commit intopython:masterfrom
Conversation
Contributor
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
hauntsaninja
approved these changes
Mar 8, 2022
Collaborator
hauntsaninja
left a comment
There was a problem hiding this comment.
Awesome, thank you!
cdce8p
pushed a commit
to cdce8p/mypy
that referenced
this pull request
Mar 10, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Moves the asterisk logic so that it is processed right away even if the following argument does not have a default value.
Fixes #11082
Test Plan
I added the example from the issue as a unit test.