Skip to content

Run build a second time when using --install-types --non-interactive #10669

Merged
JukkaL merged 8 commits intomasterfrom
non-interactive-one-step
Jun 18, 2021
Merged

Run build a second time when using --install-types --non-interactive #10669
JukkaL merged 8 commits intomasterfrom
non-interactive-one-step

Conversation

@JukkaL
Copy link
Collaborator

@JukkaL JukkaL commented Jun 18, 2021

If the first build finds missing stub packages, run the build a second
time after installing types. Only show errors from the final build.

Example output:

$ mypy --install-types --non-interactive t.py
Installing missing stub packages:
/Users/jukka/venv/mypy/bin/python3 -m pip install types-redis

Collecting types-redis
  Using cached types_redis-3.5.2-py2.py3-none-any.whl (11 kB)
Installing collected packages: types-redis
Successfully installed types-redis-3.5.2

t.py:2: error: Unsupported operand types for + ("int" and "str")
Found 1 error in 1 file (checked 1 source file)

Work on #10600.

@JukkaL JukkaL merged commit 40dfd7b into master Jun 18, 2021
@JukkaL JukkaL deleted the non-interactive-one-step branch June 18, 2021 15:58
JukkaL added a commit that referenced this pull request Jun 22, 2021
…10669)

If the first build finds missing stub packages, run the build a second
time after installing types. Only show errors from the final build.

Example output:
```
$ mypy --install-types --non-interactive t.py
Installing missing stub packages:
/Users/jukka/venv/mypy/bin/python3 -m pip install types-redis

Collecting types-redis
  Using cached types_redis-3.5.2-py2.py3-none-any.whl (11 kB)
Installing collected packages: types-redis
Successfully installed types-redis-3.5.2

t.py:2: error: Unsupported operand types for + ("int" and "str")
Found 1 error in 1 file (checked 1 source file)
```

Work on #10600.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants