Skip to content

Don't suggest installing types-pycrypto#10603

Merged
JukkaL merged 2 commits intomasterfrom
JelleZijlstra-patch-1
Jun 9, 2021
Merged

Don't suggest installing types-pycrypto#10603
JukkaL merged 2 commits intomasterfrom
JelleZijlstra-patch-1

Conversation

@JelleZijlstra
Copy link
Member

It doesn't exist, since it was removed from typeshed in October (python/typeshed#4606). Similarly, pynamodb was removed in January.

I haven't tracked down what happened to pyre-extensions in typeshed, but https://pypi.org/project/types-pyre-extensions/ doesn't exist and in any case mypy users presumably don't need it.

It doesn't exist, since it was removed from typeshed in October (python/typeshed#4606). Similarly, pynamodb was removed in January.

I haven't tracked down what happened to pyre-extensions in typeshed, but https://pypi.org/project/types-pyre-extensions/ doesn't exist and in any case mypy users presumably don't need it.
@JelleZijlstra JelleZijlstra requested a review from JukkaL June 8, 2021 23:08
@JelleZijlstra
Copy link
Member Author

Looks like I'll need to update some tests as well.

@JukkaL
Copy link
Collaborator

JukkaL commented Jun 9, 2021

Thanks for fixing this and uploading the dummy packages! I forgot to double check that the suggestions are still up to date.

@JelleZijlstra uploaded PyPI dummy packages for these so that there is no security risk. Still, I think it makes to release 0.902 with this fix, but I think that it can wait a few days at least so that we can include other fixes as well if we want.

@JukkaL JukkaL merged commit d95f24b into master Jun 9, 2021
@JukkaL JukkaL deleted the JelleZijlstra-patch-1 branch June 9, 2021 11:18
JukkaL pushed a commit that referenced this pull request Jun 10, 2021
It doesn't exist, since it was removed from typeshed in October (python/typeshed#4606). Similarly, pynamodb was removed in January.

I haven't tracked down what happened to pyre-extensions in typeshed, but https://pypi.org/project/types-pyre-extensions/ doesn't exist and in any case mypy users presumably don't need it.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants