Fixes for Windows PyPy 3.6#2363
Merged
gaborbernat merged 1 commit intopypa:mainfrom Jun 24, 2022
Merged
Conversation
Also passes unit tests in test_creator.py
Contributor
Author
|
😀 |
Contributor
Catch as in? |
Contributor
Author
|
Windows PyPy 3.6 test may throw an OSError to be fixed further. |
Contributor
|
Can you fix it? 😆 |
Contributor
Author
|
Yes. I'll check logs and do my best) |
Contributor
|
Thanks, will cut a release once we fix it 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

This seems to be a separate issue with Windows PyPy 3.6
I ran
tests/unit/create/test_creator.pyin Windows PyPy 3.6 (v7.3.3) and got errors in the same tests as CI, excepttest_create_distutils_cfg[venv]that passes locally and fails on CI, most likely due to timeout.Local tests fails when the
test_create_no_seed[venv*]checks exe files, but CI errors causes when same tests find an exception increator.debug:{ "err": "The system cannot find the file specified", "exception": "SyntaxError('invalid syntax', ('<unknown>', 0, 1, '\\n', 0))", "out": "", "returncode": 2 }The
SyntaxErrorwas happened increator.pybecause ofliteral_eval(out)whenoutis empty.I can't reproduce the exception locally, but I modified the debug info to look something like:
{ "err": "[Errno 2] The system cannot find the file specified: '<file>'", "exception": "OSError<...>", "out": "", "returncode": 2 }Windows PyPy <= 3.6 contains only
pypy3.exeandpypy3w.exeand creating a virtual environment withvenvdoes not hanlde missing executables, e.g.python.exe. Also, thestdlibpath for old PyPy versions is<host>\site-packagesinstead of<host>\Lib\site-packages.Local tests failures are fixed by creating missing executables.
Test coverage calculation is fixed by adding
stdlibpath for old PyPy versions into.coveragercsources.