Make test_setup_install_includes_dependencies work with custom PYTHONPATH set#3336
Merged
abravalheri merged 4 commits intopypa:mainfrom Jun 7, 2022
Merged
Conversation
So if the tested setuptools is only located in manually set $PYTHONPATH, it still tests that setuptools instead of the previously installed one in site-packages.
Contributor
|
Thank you very much @hroncok, sorry for the delay in reviewing/merging. In fd4a482, I have added a small news fragment based on the title of your PR. I hope you don't mind. |
Contributor
Author
|
I don't mind. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This has the same reasoning as in #3133 -- the test imported the previously installed setuptools version in our environment and since that version did not yet use
__EASYINSTALL_INDEX, it reached https://pypi.org/simple/ instead. That way, we recognized it as a problem. If the installed version had already used__EASYINSTALL_INDEX, we would probably never realize that it is the installed version that is being tested here.The three individual commits follow my train of thoughts, so I preserved them here separated, for easier review.
pytest.raisesdetour -- happy to revert if there was a reason for it$PYTHONPATHvalue instead of overriding it, making it actually work in our environmentinstall_rootto$PYTHONPATHis not necessary for this test, so I removed it -- happy to squash that to the previous one if you prefer thatThanks.