Skip to content

Minor changes to the User Guide's Package Discovery page#3332

Merged
abravalheri merged 5 commits intopypa:mainfrom
codeandfire:package-discovery-fix
May 20, 2022
Merged

Minor changes to the User Guide's Package Discovery page#3332
abravalheri merged 5 commits intopypa:mainfrom
codeandfire:package-discovery-fix

Conversation

@codeandfire
Copy link
Copy Markdown
Contributor

@codeandfire codeandfire commented May 20, 2022

Summary of changes

  1. Grammar fixes: "namespace package" -> "namespace packages" and other such small fixes.
  2. Modified directory trees shown to illustrate src-layout and flat-layout, by adding two package directories mypkg1 and mypkg2 instead of a single package directory mypkg. This is in order to improve consistency with the previous example which shows two packages mypkg1 and mypkg2, and make it clear that multiple packages are allowed.
  3. Typo fix: "aditional" -> "additional"

Pull Request Checklist

Since the previous example on manually specifying `packages` and
`package_dir` alludes to two packages, `mypkg1` and `mypkg2`, IMHO it
would be more consistent to continue this and show two packages in the
directory trees for the src-layout and flat-layout, instead of showing a
single package `mypkg`. This would also make it more clear that multiple
packages are allowed.
@codeandfire codeandfire marked this pull request as ready for review May 20, 2022 06:05
@abravalheri abravalheri merged commit b7c2a06 into pypa:main May 20, 2022
@abravalheri
Copy link
Copy Markdown
Contributor

Thank you very much @codeandfire

@codeandfire codeandfire deleted the package-discovery-fix branch May 20, 2022 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants