In Distribution.finalize_options, suppress known removed entry points#2768
Merged
In Distribution.finalize_options, suppress known removed entry points#2768
Conversation
… for a year to avoid issues with older Setuptools. Fixes #2765.
Member
Author
|
In this change, I propose a horizon of 1 year to suppress the error messages, under the presumption that after 1 year, there will be few environments that have an implicit version of an older Setuptools present when building Setuptools. The advantage of this approach is that it makes it explicit when this behavior goes away. The disadvantage is that the horizon is committed in this and subsequent releases. I'm now thinking that a code-based change would be better (that is, just a comment saying when to remove the behavior). |
f2ee82f to
6041353
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
...
for a yearto avoid issues with older Setuptools. Fixes #2765.