fix: warning when building macOS arm64 wheels#1312
Merged
Conversation
When `MACOSX_DEPLOYMENT_TARGET` is not set by the user, cibuildwheel always defaults to `10.9`. This leads to warning when building arm64 wheels. This commit removes the warning by setting the default to `11.0` for arm64 builds.
Member
Author
|
I chose to add the test in an existing one not increase test time. |
Contributor
|
@mayeut i hope it's okay I added another test to this, just checking that the warning is detected by forcing it to be produced with a |
henryiii
approved these changes
Oct 17, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
MACOSX_DEPLOYMENT_TARGETis not set by the user, cibuildwheel always defaults to10.9. This leads to a warning when building arm64 wheels.This commit removes the warning by setting the default to
11.0for arm64 builds.Reported in #1300 (comment)