Skip to content

Add GitHub's Dark Style#2192

Merged
jeanas merged 4 commits intopygments:masterfrom
icy-comet:style/gh-dark
Jul 27, 2022
Merged

Add GitHub's Dark Style#2192
jeanas merged 4 commits intopygments:masterfrom
icy-comet:style/gh-dark

Conversation

@icy-comet
Copy link
Copy Markdown
Contributor

@icy-comet icy-comet commented Jul 27, 2022

The PR adds a new Pygments style based on GitHub's Dark Colorscheme.

Sample screenshot:
image

@icy-comet icy-comet requested a review from jeanas July 27, 2022 11:57
@jeanas
Copy link
Copy Markdown
Contributor

jeanas commented Jul 27, 2022

As CI tells you, you also need to run scripts/update-contrasts.py.

@icy-comet
Copy link
Copy Markdown
Contributor Author

icy-comet commented Jul 27, 2022

As CI tells you, you also need to run scripts/update-contrasts.py.

Although I have the wcag_contrast_ratio package installed in my virtual environment, running the script throws an error saying that the package is not found. @jean-abou-samra

I tried running it before opening the PR.

Running py -m pip install --upgrade wcag_contrast_ratio says the requirement is already satisfied.

@jeanas
Copy link
Copy Markdown
Contributor

jeanas commented Jul 27, 2022

How are you running Python exactly? In particular, did you activate the venv before running both pip and the script?

@icy-comet
Copy link
Copy Markdown
Contributor Author

icy-comet commented Jul 27, 2022

How are you running Python exactly? In particular, did you activate the venv before running both pip and the script?

Yes, I did activate the environment. Seems like it was the Python Launcher for Windows causing the issue. Added the commit now.

@jeanas jeanas merged commit 4dba17e into pygments:master Jul 27, 2022
@jeanas
Copy link
Copy Markdown
Contributor

jeanas commented Jul 27, 2022

Thanks!

@jeanas jeanas added the changelog-update Items which need to get mentioned in the changelog label Jul 27, 2022
@icy-comet icy-comet deleted the style/gh-dark branch July 27, 2022 12:28
@Anteru Anteru added this to the 2.13.0 milestone Aug 14, 2022
@Anteru Anteru added A-theming area: changes to themes and removed changelog-update Items which need to get mentioned in the changelog labels Aug 14, 2022
@jeanas
Copy link
Copy Markdown
Contributor

jeanas commented Sep 17, 2022

I have reported @aswadshiraz as spam to GitHub.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-theming area: changes to themes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants