nim: types shouldn't be highlighted as keywords#2136
nim: types shouldn't be highlighted as keywords#2136jeanas merged 2 commits intopygments:masterfrom narimiran:fix-nim
Conversation
|
Could you explain the rationale behind this change? Keyword.Type isn't highlighted the same as Keyword in the default style, e.g.: If you are using another style that doesn't have a rule for Keyword.Type, it might be a matter of adding it. Now, another reason for changing to Name would be if these aren't really reserved keywords (like type names are in, e.g., Python -- they're just built-in objects in the default namespace, they can be rebound if you really want to), but in that case wouldn't Name.Builtin be a better fit? |
|
I'd like to add that you can see in the diff view that Github also colors the types... |
Correct.
Probably. I'll update my PR. |
|
Sounds fine to me. @birkenfeld WDYT? |
|
Sure! |

This was requested by the author of Nim himself: @Araq.