Conversation
The doc string indicates that the linenos table is wrapped in <div class="highlight">, but the actual implementation puts the <div> inside the table cell containing the code. This seems to cause issues as explained in #632, and given it doesn't match the documentation, this PR restores the original behavior.
|
I can't claim I understand everything in the HtmlFormatter, but what I understand in this patch LGTM. |
Instead of calling _wrap_div() at the end of wrap(), _wrap_div() is now called after wrap/_wrap_tablinelinenos. This yields the desired behavior but removes the custom <div> generation code.
|
I think the logic was actually quite broken :/ Second try (I noticed some unit tests would look different by default.) |
|
Mmmh, I replied to a GitHub notification by email yesterday: "Sorry for dropping the ball. I'll try to review this again tomorrow". Not sure why it didn't reach this PR, maybe it doesn't work for requests for review? Nevertheless, I'm OK with the merge. |
|
:( I didn't get notified, and I figured I'll finally set aside some time to make a release so I didn't want to delay this even further. I think the logic is right now and if not I'll do a 2.12.1 soon. |
|
Now I'm receiving notifications from other people in other projects that look as if they were from you. GitHub isn't being kind to me :-( Edit: I actually figured it came from my mail client. |
|
Glad to hear you got it sorted out, and thanks for taking care of the related issue. If that's all the fallout we'll get I'll be quite happy. |
This is fighting pygments/pygments#2101
The doc string indicates that the linenos table is wrapped in
<div class="highlight">,but the actual implementation puts the
<div>inside the table cell containing the code.This seems to cause issues as explained in #632, and given it doesn't match the
documentation, this PR restores the original behavior.