Merge lexer support for ANSI-standard MUMPS#2089
Open
saint-erk wants to merge 259 commits intopygments:masterfrom
Open
Merge lexer support for ANSI-standard MUMPS#2089saint-erk wants to merge 259 commits intopygments:masterfrom
saint-erk wants to merge 259 commits intopygments:masterfrom
Conversation
…in string comparison test
jeanas
requested changes
Mar 21, 2022
Contributor
jeanas
left a comment
There was a problem hiding this comment.
Some preliminary review, didn't get to the core parts as this is quite large. I think that by refactoring the lexer you will be able to simplify it enormously.
jeanas
reviewed
Jun 28, 2022
Contributor
jeanas
left a comment
There was a problem hiding this comment.
A few more comments and I think we're good to go.
Comment on lines
+56
to
+59
| if re.search(r'^[%A-Za-z][A-Za-z0-9]* ;', text): | ||
| return 0.3 | ||
| if re.search(r'^[%A-Za-z][A-Za-z0-9]*\n', text): | ||
| return 0.1 |
Contributor
There was a problem hiding this comment.
Aren't there some more specific ways to recognize MUMPS? There patterns are very unspecific, it seems to me that they will trigger on many languages ...
Author
There was a problem hiding this comment.
True, I will work on finding some patterns that have better matching. The joys of old terse languages that existed on dedicated machines...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Creates a lexer, lexer tests, and example files for the MUMPS programming language, using the ANSI M standard.