Elpi: fix catastrophic backtracking#2061
Conversation
birkenfeld
left a comment
There was a problem hiding this comment.
The reformatting makes it basically impossible to see what has really changed.
Please don't apply black to the Pygments codebase, as you can see we have a pretty different style.
OK, I'll back the formatting out. Note, though, that it is in a separate commit for the purpose of review (I've been trained rigorously to use atomic commits, but maybe that is not usual here?). |
|
As far as I can see, the formatting changes in the first commit ("minor changes") which also has a bunch of other (useful) things? |
Of course it's useful, but even with atomic commits I wouldn't expect to see a wholesale reformatting in a PR to fix a bug :-) |
|
I have refactored this PR to include only the bugfix. |
Closes #2053