php: update builtin functions lists#2056
Merged
birkenfeld merged 1 commit intomasterfrom Jan 31, 2022
Merged
Conversation
Merged
ancarda
approved these changes
Jan 29, 2022
Contributor
ancarda
left a comment
There was a problem hiding this comment.
This looks good to me, thank you!
Despite being a large diff, this does include the 8.x functions like array_is_list and drops the removed functions like import_request_variables.
It seems a lot of old extensions I've never heard of were dropped too, like Hyperwave. These are still available via PECL, so shouldn't be included for highlighting like this. They aren't standard library functions anymore.
Collaborator
|
I carefully looked through all functions you've changed/added and I didn't see any issues. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.