Conversation
|
Macaulay2 1.18 was just released, so I've pushed a new commit with some updated symbols. |
|
I notice there's an "updated needed" label. What update is requested? |
Looks like I forgot to request changes when I reviewed. My bad -- sorry. Should be online now. |
No problem! I believe I've addressed the comments. |
|
Just pushed a couple new commits addressing the comments. |
Instead of matching each character one at a time, we match all characters without special meaning together.
|
I've pushed a new commit addressing the latest comments (plus another updating the test output). |
|
Thanks, that looks much better now. I'll merge this soon, just waiting for any post 2.10 fallout which might require a point release. |
|
I've just pushed a new commit updating the symbols for the latest release of Macaulay2. |
|
Can you please move the comment somewhere further down the file? The automated check expects each file to start with a docstring. |
Done! |
|
Am I correct that the failed test is unrelated to this pull request? =================================== FAILURES ===================================
____________________ test_long_unclosed_javascript_fragment ____________________
lexer_html = <pygments.lexers.HtmlLexer>
def test_long_unclosed_javascript_fragment(lexer_html):
"""unclosed, long Javascript fragments should parse quickly"""
reps = 2000
fragment = "<script type=\"text/javascript\">"+"alert(\"hi\");"*reps
start_time = time.time()
tokens = list(lexer_html.get_tokens(fragment))
> assert time.time() - start_time < MAX_HL_TIME, \
'The HTML lexer might have an expensive error script case'
E AssertionError: The HTML lexer might have an expensive error script case
E assert (1638127016.9544926 - 1638127006.3483639) < 10
E + where 1638127016.9544926 = <built-in function time>()
E + where <built-in function time> = time.time
/home/runner/work/pygments/pygments/tests/test_html_lexer.py:53: AssertionError
=========================== short test summary info ============================
FAILED tests/test_html_lexer.py::test_long_unclosed_javascript_fragment - Ass...
============ 1 failed, 3809 passed, 12 skipped in 390.88s (0:06:30) ============
make: *** [Makefile:54: test] Error 1 |
|
This is PyPy3 failing and it's been very flaky recently, so yes, unrelated. @birkenfeld any concerns disabling PyPy3 until we find a way to make it not fail with 50% chance? |
|
Sure! |
|
I noticed that this was bumped to the next release milestone. I believe all the requested changes have been addressed -- am I missing something? |
|
No, I just had to make the cut somewhere for the release (and that still went not as great as hoped for ...) It's firmly going into the next one, assuming the fallout from the current one is resolved (and to avoid creating a release branch for point releases I'm not merging this yet.) |
|
I've updated this branch so it no longer conflicts with |
|
Dang it, this fails due to a missing copyright string. Can you please check once more and I'll merge this tomorrow? Sorry for leaving you hanging here more than half a year :( |
The test passes after I bump the final copyright year from 2021 to 2022. I just pushed a commit with the fix. |
|
Thanks. Assuming CI passes this goes in -- thanks again for your contribution! |
Macaulay2 is a computer algebra system that is widely used for research in algebraic geometry and commutative algebra. It comes with its own programming language, and it would be great if support were added to Pygments, e.g., for syntax highlighting Macaulay2 code in journal articles using minted.
The lists of symbols are generated automatically using the script
make-M2-symbols.m2in the Macaulay2 source. See Macaulay2/M2#2040.