Fix for lexing Python raw f-strings with backslashes#1683
Merged
Anteru merged 4 commits intopygments:masterfrom Jan 17, 2021
jmd-dk:fix1681
Merged
Fix for lexing Python raw f-strings with backslashes#1683Anteru merged 4 commits intopygments:masterfrom jmd-dk:fix1681
Anteru merged 4 commits intopygments:masterfrom
jmd-dk:fix1681
Conversation
Collaborator
|
Thanks for preparing the fix! Can you please add an unit test for this as well? |
Contributor
Author
I've added three tests; one for just "rawness", one for just usual f-string behavior and one for the previously missing combined behavior. |
Contributor
Author
|
@Anteru Note that I've rewritten the old (r'\{\{', String.Escape),
(r'\}\}', String.Escape),twice. Is this done correctly? |
Collaborator
|
Sounds reasonable to me, thanks for the contribution! |
This was referenced Mar 8, 2021
This was referenced Mar 12, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix for #1681
'rfstringescape', used for raw f-strings.'fstringescape'as a composite of'rfstringescape'and'stringescape'.