Merged
Conversation
sfdye
approved these changes
Oct 25, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes type definitions for:
This was prompted by
mypyfailing on some of my code, because types forRepository.is_template()were missing.The missing/incorrect types were found by running (for example):
and going through each result manually.
If there's a more automated way to do this, I'd be keen to hear about it!
FWIW there are a large number of types that need a bit of attention. I was thinking of raising a PR to run
mypy.stubtestin CI, but there are a lot of fixes to make before that could run green, so I thought it would be easier to review / merge these fixes in chunks.