Remove client_id/client_secret authentication#1888
Merged
s-t-e-v-e-n-k merged 1 commit intoPyGithub:masterfrom Mar 23, 2021
Merged
Remove client_id/client_secret authentication#1888s-t-e-v-e-n-k merged 1 commit intoPyGithub:masterfrom
s-t-e-v-e-n-k merged 1 commit intoPyGithub:masterfrom
Conversation
Authenticating via client_id and client_secret is dangerous, since they appended to the query string, and can be easily seen from the URL. client_id/client_secret have been deprecated since May 2020, and ignored by GitHub since late 2020, so it's high time they were removed.
2441a3c to
d054984
Compare
Codecov Report
@@ Coverage Diff @@
## master #1888 +/- ##
==========================================
- Coverage 98.88% 98.88% -0.01%
==========================================
Files 108 108
Lines 11052 11042 -10
==========================================
- Hits 10929 10919 -10
Misses 123 123
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Authenticating via client_id and client_secret is dangerous, since they
appended to the query string, and can be easily seen from the URL.
client_id/client_secret have been deprecated since May 2020, and ignored
by GitHub since late 2020, so it's high time they were removed.