Add default arguments to Workflow method type annotations#1857
Merged
s-t-e-v-e-n-k merged 1 commit intoPyGithub:masterfrom Mar 24, 2021
jwodder:workflow-defaults
Merged
Add default arguments to Workflow method type annotations#1857s-t-e-v-e-n-k merged 1 commit intoPyGithub:masterfrom jwodder:workflow-defaults
s-t-e-v-e-n-k merged 1 commit intoPyGithub:masterfrom
jwodder:workflow-defaults
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The type annotations for
Workflow.create_dispatch()andWorkflow.get_runs()do not include the fact that some of the arguments have default values. As a result, user code that calls, say,workflow.get_runs()without specifying any arguments will not validate with mypy. This PR fixes that.