Conversation
6b6031f to
2ce6ec5
Compare
Codecov Report
@@ Coverage Diff @@
## master #1681 +/- ##
=======================================
Coverage 98.67% 98.67%
=======================================
Files 48 48
Lines 2561 2561
=======================================
Hits 2527 2527
Misses 34 34 Continue to review full report at Codecov.
|
|
Could we add List Organization Secrets (https://docs.github.com/en/free-pro-team@latest/rest/reference/actions#list-organization-secrets) to this as well? |
|
Tested and works great for my needs! (I just needed to loop through about 100 repositories and add a secret, and it worked for that, as well as updating the secret). It would be great to support the other methods as well, but I'd love to see this merged as a start as repo secrets are by far the most annoying thing to manage for personal account repositories. At least for orgs, you can add one secret for all the org's repos! |
|
@sfdye or @s-t-e-v-e-n-k could you please address this PR? thanks. |
|
will check |
|
@pdex Could you resolve the merge conflicts first? |
|
What's the status of the PR? The only merge conflict appears to be in requirements / setup.py I'd be happy to resolve it from a fork if necessary, but I'm not sure if that's the main or only open question. |
|
@akhmerov thanks for the bump, I'll get that sorted. |
|
@sfdye or @s-t-e-v-e-n-k the merge conflict has been resolved. Dependency on pynacl has been set to |
|
Thanks for resolving the conflicts. Looks like the lint checks failed, you can fix it by following: https://github.com/PyGithub/PyGithub/blob/master/CONTRIBUTING.md#coding-style |
|
@sfdye all checks are passing. |
Co-authored-by: Liuyang Wan <tsfdye@gmail.com>
|
@sfdye Permission to merge? |
|
Yes, merge at your will |
|
Could secrets also be included in a new release after the merge? |
|
Definitely we can cut a new release for secrets
…________________________________
From: Anton Akhmerov <notifications@github.com>
Sent: Friday, March 5, 2021 7:18:13 AM
To: PyGithub/PyGithub <PyGithub@noreply.github.com>
Cc: Liuyang Wan <tsfdye@gmail.com>; Mention <mention@noreply.github.com>
Subject: Re: [PyGithub/PyGithub] Adding github actions secrets (#1681)
Could secrets also be included in a new release after the merge?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub<#1681 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AAHYERWSB6L4P6QWQ4HBLBLTCAILLANCNFSM4QTRYXDQ>.
|
|
@sfdye I don't have write permission, could you please merge? |
This adds the ability to create repository secrets.
If merged this PR will add a dependency on pynacl.