Skip to content

Update plone profile: copy of black, plus three settings.#1926

Merged
timothycrosley merged 1 commit intoPyCQA:mainfrom
mauritsvanrees:issue/1925
May 11, 2022
Merged

Update plone profile: copy of black, plus three settings.#1926
timothycrosley merged 1 commit intoPyCQA:mainfrom
mauritsvanrees:issue/1925

Conversation

@mauritsvanrees
Copy link
Copy Markdown
Contributor

@mauritsvanrees mauritsvanrees commented May 3, 2022

Fixes #1925

The Plone-related tests pass, three others fail. Should be unrelated, or maybe a bad setup locally:

FAILED tests/unit/test_literal.py::test_value_assignment_list - isort.exceptions.FormattingPluginDoesNotExist: Specified formatting plugin of example does not exist.
FAILED tests/unit/test_ticketed_features.py::test_isort_supports_formatting_plugins_issue_1353 - isort.exceptions.FormattingPluginDoesNotExist: Specified formatting plugin of example does not exist.
FAILED tests/unit/test_ticketed_features.py::test_isort_literals_issue_1358 - isort.exceptions.FormattingPluginDoesNotExist: Specified formatting plugin of example does not exist.

Also, ./scripts/test.sh fails because some security updates need to be added, so poetry update needs to run, but that fails, see issue #1915.

@mauritsvanrees mauritsvanrees mentioned this pull request May 3, 2022
Closed
ale-rt
ale-rt approved these changes May 6, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@ale-rt ale-rt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jensens
Copy link
Copy Markdown

jensens commented May 11, 2022

LGTM, it reflects our community code formatting rules for Plone 6.

@ale-rt
Copy link
Copy Markdown
Contributor

ale-rt commented May 11, 2022

FYI @timothycrosley ^

@timothycrosley timothycrosley merged commit 2cb757e into PyCQA:main May 11, 2022
@mauritsvanrees mauritsvanrees deleted the issue/1925 branch May 11, 2022 12:17
@wesleybl wesleybl mentioned this pull request Aug 5, 2022
Merged
4 tasks
@ale-rt ale-rt mentioned this pull request Jan 28, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@ale-rt ale-rt ale-rt approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Update plone profile

4 participants

@mauritsvanrees @jensens @ale-rt @timothycrosley