ENH: Add PageObject.user_unit property#1336
Merged
MartinThoma merged 3 commits intomainfrom Sep 14, 2022
Merged
Conversation
MasterOdin
reviewed
Sep 8, 2022
This comment was marked as outdated.
This comment was marked as outdated.
Codecov ReportBase: 94.82% // Head: 94.82% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #1336 +/- ##
=======================================
Coverage 94.82% 94.82%
=======================================
Files 30 30
Lines 5097 5100 +3
Branches 1049 1049
=======================================
+ Hits 4833 4836 +3
Misses 154 154
Partials 110 110
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Co-authored-by: Matthew Peveler <matt.peveler@gmail.com>
This comment was marked as outdated.
This comment was marked as outdated.
MartinThoma
added a commit
that referenced
this pull request
Sep 14, 2022
New Features (ENH): - Add PageObject.user_unit property (#1336) Robustness (ROB): - Improve NameObject reading/writing (#1345) Full Changelog: 2.10.7...2.10.8
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context of this PR: #1333