fix: parse statusText from the extraInfo event#7798
Merged
Conversation
Collaborator
Author
|
@josepharhar PTAL (extracted your change from #7640) |
josepharhar
approved these changes
Nov 25, 2021
Contributor
|
Does this include the test I added with empty status text? |
Collaborator
Author
|
Overlooked it: I am gonna add it in a moment. |
0394fb0 to
6ad0b24
Compare
6ad0b24 to
3823a21
Compare
Comment on lines
+105
to
+107
| const firstLine = extraInfo.headersText.split('\r', 1)[0]; | ||
| if (!firstLine) return; | ||
| const match = firstLine.match(/[^ ]* [^ ]* (.*)/); |
Collaborator
There was a problem hiding this comment.
It would be great to have unit testы on this parsing.
Collaborator
Author
There was a problem hiding this comment.
yeah, the reason is that Puppeteer does not have unit tests. The tests that are called "unit" are added with this PR (one existing test and one empty status text test).
Collaborator
|
It would be really great to have the parsing unit-tested. If you have some strong reasons not to do it, please clarify them and go ahead with merging. |
sadym-chromium
approved these changes
Nov 26, 2021
This was referenced May 30, 2022
This was referenced May 30, 2022
This was referenced May 30, 2022
This was referenced Jun 13, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issues: #7458