fix(ariaqueryhandler): allow single quotes in aria attribute selector#7750
Merged
Conversation
This updates the regular expression used to parse aria attribute selectors so that single quotes may be used as an alternative to double quotes, e.g. `aria/Single button[role='button']`. Issues: puppeteer#7721
johanbay
approved these changes
Nov 9, 2021
johanbay
left a comment
Contributor
There was a problem hiding this comment.
LGTM. Thanks for adding this!
This was referenced May 30, 2022
This was referenced May 30, 2022
This was referenced May 30, 2022
This was referenced Jun 13, 2022
This was referenced Jan 25, 2023
This was referenced Jul 4, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This updates the regular expression used to parse aria attribute
selectors so that single quotes may be used as an alternative to double
quotes, e.g.
aria/Single button[role='button'].Issues: #7721