Gracefully handle Rack not accepting CLI options#2630
Merged
nateberkopec merged 1 commit intopuma:masterfrom May 20, 2021
Merged
Conversation
In rack/rack@b95cb72#diff-79892c6315a7f9c02489803e95ce828a8a32759b9f8f196aa98e6826eb562e55R96, Rack removed the ability to pass options from the command line. It now fails when you try to do that, and no longer exposes them from `Builder.load_file`. Puma shouldn't fail when this happens. This commit falls back to an empty object when Rack does not pass options back from `Builder.load_file`.
JuanitoFatas
pushed a commit
to JuanitoFatas/puma
that referenced
this pull request
Sep 9, 2022
In rack/rack@b95cb72#diff-79892c6315a7f9c02489803e95ce828a8a32759b9f8f196aa98e6826eb562e55R96, Rack removed the ability to pass options from the command line. It now fails when you try to do that, and no longer exposes them from `Builder.load_file`. Puma shouldn't fail when this happens. This commit falls back to an empty object when Rack does not pass options back from `Builder.load_file`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Closes #2626
In rack/rack@b95cb72#diff-79892c6315a7f9c02489803e95ce828a8a32759b9f8f196aa98e6826eb562e55R96, Rack removed the ability to pass options from the command line. It now fails when you try to do that, and no longer exposes them from
Builder.load_file. Puma shouldn't fail when this happens.This commit falls back to an empty object when Rack does not pass options back from
Builder.load_file.Your checklist for this pull request
[ci skip]to the title of the PR.#issue" to the PR description or my commit messages.