Fix several ResourceWarnings in test_requests.py#4766
Fix several ResourceWarnings in test_requests.py#4766nateprewitt merged 1 commit intopsf:mainfrom BoboTiG:fix-resource-warnings
Conversation
Codecov Report
@@ Coverage Diff @@
## master #4766 +/- ##
=======================================
Coverage 66.89% 66.89%
=======================================
Files 15 15
Lines 1577 1577
=======================================
Hits 1055 1055
Misses 522 522Continue to review full report at Codecov.
|
nateprewitt
left a comment
There was a problem hiding this comment.
Hi @BoboTiG, thanks for looking into this. I don't have an issue adding the context handlers, but we should probably avoid dumping all of the logic inside of them.
If we want to encourage best practices, let's make sure anything not relevant to the file handler stays at its original indentation. Once that's done, if you can rebase onto master, I think I'm happy with this.
|
@nateprewitt, thanks for the review. You are totally right and I applied changes + rebase on master :) We only need to keep |
|
What is the status of the PR? Would you mind trigger the request-CI job? |
|
Ping :) |
nateprewitt
left a comment
There was a problem hiding this comment.
Hi @BoboTiG, I've rebased your change onto the top of our main branch and resolved some conflicts. This seems like a reasonable fix still and I think we're happy with its current state. Thanks again for the contribution!
Hello,
I do not know if you are interested in fixing
ResourceWarnings in tests, but I will take my chance :)There was 10 unclosed files in
test_requests.py.