Fix build on AIX and SunOS (#8373)#9065
Fix build on AIX and SunOS (#8373)#9065acozzette merged 1 commit intoprotocolbuffers:masterfrom scddev:fix-aix-build
Conversation
scddev
commented
Oct 6, 2021
- fix includes for AIX and SunOS
* fix includes for AIX and SunOS
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
|
@googlebot I signed it! |
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
|
Are people still using pre-Solaris SunOS? Or is this for Solaris? I wonder if we could set up a Github action on one or both of these platforms to test this? |
|
In my case I used Solaris 10, so maybe Solaris would be the better name. I can modify the commit message if you like. |
|
@googlebot I signed it! |
|
Can we make sure that any AIX fix includes support for xlC and gcc compilers on AIX. |
|
@gdharley Are you asking that we also support xLC and gcc, or are you worried that this might break support that is already working? |
|
We use gcc on AIX and while protobufs compile, there are linking issues with libstdc++ which means protoc when executed has missing symbols. I have tried linking against every libstdc++ available and always different symbols are missing. Have manually edited the Makefile and can't see anything wrong. |
|
To get around the dependencies to libstdc++ or libgcc we use LDFLAGS Btw, we are using the cmake build instead of the autotools build. But also cmake build needs some tweaks to work. For AIX we are using a toolchain file as cmake by default generates some commands wrong (ar, ranlib). |
|
Thanks Dietmar, I thought I had tried static linking, will try again. |
|
To get you started, here my toolchain.cmake: Now I can build with: This yields: |
|
@scddev Thanks for the fix! |