Avoid installing anything from Homebrew in test runs#9043
Merged
acozzette merged 1 commit intoprotocolbuffers:3.18.xfrom Oct 1, 2021
Merged
Avoid installing anything from Homebrew in test runs#9043acozzette merged 1 commit intoprotocolbuffers:3.18.xfrom
acozzette merged 1 commit intoprotocolbuffers:3.18.xfrom
Conversation
Installing and upgrading Homebrew packages is taking quite a lot of time (around 20-30 minutes) for each run. This commit removes all Homebrew usage from the test runs. Homebrew may have been necessary at some point in the past, but now it appears that everything works without it. The preinstalled build tools seem to be sufficient for building protoc, and Ruby is something we already get from rvm.
thomasvl
approved these changes
Oct 1, 2021
Contributor
thomasvl
left a comment
There was a problem hiding this comment.
LG for the cocoapods tests.
Author
|
I believe the Ruby 3.0 failure is an issue with RVM and isn't related to this change, so it appears that everything does still work without us needing Homebrew. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Installing and upgrading Homebrew packages is taking quite a lot of time
(around 20-30 minutes) for each run. This commit removes all Homebrew
usage from the test runs. Homebrew may have been necessary at some point
in the past, but now it appears that everything works without it. The
preinstalled build tools seem to be sufficient for building protoc, and
Ruby is something we already get from rvm.