Skip to content

Added "object" as a reserved name for PHP#8962

Merged
acozzette merged 2 commits intoprotocolbuffers:masterfrom
J0sh0nat0r:master
Oct 12, 2021
Merged

Added "object" as a reserved name for PHP#8962
acozzette merged 2 commits intoprotocolbuffers:masterfrom
J0sh0nat0r:master

Conversation

@J0sh0nat0r
Copy link
Copy Markdown
Contributor

"Object" is a reserved word as of PHP 7.2, as stated here

@google-cla
Copy link
Copy Markdown

google-cla Bot commented Sep 10, 2021

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@google-cla google-cla Bot added the cla: no label Sep 10, 2021
@J0sh0nat0r
Copy link
Copy Markdown
Contributor Author

@googlebot I signed it!

@google-cla google-cla Bot added cla: yes and removed cla: no labels Sep 10, 2021
@acozzette acozzette merged commit 8171716 into protocolbuffers:master Oct 12, 2021
@acozzette
Copy link
Copy Markdown

Thanks, @J0sh0nat0r.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants