Support arena allocation of google::protobuf::AnyMetadata#8758
Merged
acozzette merged 1 commit intoprotocolbuffers:masterfrom Jul 12, 2021
Merged
Support arena allocation of google::protobuf::AnyMetadata#8758acozzette merged 1 commit intoprotocolbuffers:masterfrom
acozzette merged 1 commit intoprotocolbuffers:masterfrom
Conversation
georgthegreat
commented
Jun 23, 2021
| bool is_message_owned) | ||
| : ::PROTOBUF_NAMESPACE_ID::Message(arena, is_message_owned), | ||
| _any_metadata_(&type_url_, &value_) { | ||
| _any_metadata_(arena, &type_url_, &value_) { |
Contributor
Author
There was a problem hiding this comment.
NB:
Local regeneration of any.pb.cc from any.proto removes some PROTOBUF_EXPORT statements from any.pb.h.
I did not included these changes into PR.
|
@georgthegreat Thanks for the fix! Looks pretty good but I have just a couple comments:
|
3ab3c6a to
d631469
Compare
Contributor
Author
|
@acozzette, this PR should fix the problem in a proper way. Unfortunately, running Patches in protobuf/compiler might be incorrect. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #8264