Stop using std::iterator (deprecated in C++17).#8741
Merged
acozzette merged 1 commit intoprotocolbuffers:masterfrom Jun 28, 2021
Merged
Stop using std::iterator (deprecated in C++17).#8741acozzette merged 1 commit intoprotocolbuffers:masterfrom
acozzette merged 1 commit intoprotocolbuffers:masterfrom
Conversation
63003a5 to
e3675f9
Compare
Contributor
Author
|
@fowles looks like you're the one to poke about C++ reviews? PTAL :) |
Contributor
|
They are not available for the moment, so I've assigned @dlj-NaN who can also review this. |
|
Thanks, @Quuxplusone. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #7120
Fixes #5416 (maybe?)
Weirdly, the changelog claims that this was already fixed in