Skip to content

Fix constness issue detected by MSVC standard conforming mode#8568

Merged
acozzette merged 1 commit intoprotocolbuffers:masterfrom
georgthegreat:patch-1
May 6, 2021
Merged

Fix constness issue detected by MSVC standard conforming mode#8568
acozzette merged 1 commit intoprotocolbuffers:masterfrom
georgthegreat:patch-1

Conversation

@georgthegreat
Copy link
Copy Markdown
Contributor

@georgthegreat georgthegreat commented May 5, 2021 •
edited
Loading

This is the continuation of #8344

Original error is (formatting is mine):

error C2664: 'PyObject* google::protobuf::python::cdescriptor_pool::SetErrorFromCollector(
  google::protobuf::DescriptorPool::ErrorCollector *,
  char *,
  char*
)': cannot convert argument 3 from 'const char [5]' to 'char *'

@google-cla google-cla Bot added the cla: yes label May 5, 2021
@acozzette acozzette merged commit c8389f8 into protocolbuffers:master May 6, 2021
@georgthegreat georgthegreat deleted the patch-1 branch May 6, 2021 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

cla: yes python

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@georgthegreat @acozzette @protobuf-kokoro