Fixed SEGV when users pass nil messages. This also disallows nil in RepeatedField or Map.#8363
Merged
haberman merged 2 commits intoprotocolbuffers:3.15.xfrom Mar 3, 2021
Merged
Conversation
acozzette
approved these changes
Mar 2, 2021
This was referenced Mar 7, 2021
This was referenced Mar 14, 2021
Closed
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We cannot have nil messages in repeated fields or maps, it is semantically undefined what it would mean to serialize that. It is a bug that nil messages were ever allowed.
Fixes: #8359