Fix compiler warnings issue found in conformance_test_runner#8189#8190
Merged
dlj-NaN merged 1 commit intoprotocolbuffers:masterfrom Feb 12, 2021
Merged
Conversation
Contributor
Author
|
This is a fix for this issue - [C++] Compiler warnings showing in conformance_test_runner #8189 |
Contributor
Author
|
Please add label:c++ and release notes:yes |
TeBoring
reviewed
Jan 7, 2021
03ac7a1 to
3aaffa6
Compare
Contributor
Author
|
@TeBoring, Please review the changes, and help to add label:c++ & release notes:yes |
Contributor
Author
|
@TeBoring @acozzette Please review the changes, and help to add label:c++ & release notes:yes |
Signed-off-by: Abhishek Jain <abhishek.jain3@huawei.com>
3aaffa6 to
930815b
Compare
Contributor
Author
|
Please help to review, and merge this change. |
dlj-NaN
approved these changes
Feb 12, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Abhishek Jain abhishek.jain3@huawei.com