Skip to content

Remove Abseil dependency from CMake build#10056

Merged
acozzette merged 2 commits intoprotocolbuffers:21.xfrom
acozzette:absl
May 26, 2022
Merged

Remove Abseil dependency from CMake build#10056
acozzette merged 2 commits intoprotocolbuffers:21.xfrom
acozzette:absl

Conversation

@acozzette
Copy link
Copy Markdown

@acozzette acozzette commented May 26, 2022

We will reintroduce this soon, but we do not want it to take effect yet in the current 3.21 release.

@acozzette acozzette requested a review from mkruskal-google May 26, 2022 19:10
@acozzette acozzette merged commit f7e2e0b into protocolbuffers:21.x May 26, 2022
@acozzette acozzette deleted the absl branch May 26, 2022 19:13
Mizux
Mizux reviewed Jun 13, 2022
View reviewed changes
Comment thread kokoro/release/python/linux/build_artifacts.sh
# IMPORTANT: always pin multibuild at the same commit for:
# - linux/build_artifacts.sh
# - macos/build_artifacts.sh
# - linux/build_artifacts.sh
Copy link
Copy Markdown
Contributor

@Mizux Mizux Jun 13, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should NOT have been reverted same below

@h-vetinari h-vetinari mentioned this pull request Sep 4, 2022
Open
@yoavmil
Copy link
Copy Markdown
Contributor

yoavmil commented Sep 29, 2022

note that when I tried to install protobuf via vcpkg it gave an error message.
the install command:

PS ...\vcpkg> vcpkg upgrade protobuf:x64-windows --no-dry-run
The following packages will be rebuilt:
  * grpc[codegen,core]:x64-windows -> 1.49.0
  * protobuf[core]:x64-windows -> 3.21.6

the error message:

Error: Building package grpc:x64-windows failed with: BUILD_FAILED

and inside the log file:

CMake Error at CMakeLists.txt:2407 (target_link_libraries):
  Target "grpc" links to:

    absl::any_invocable

 vcpkg --version
Vcpkg package management program version 2022-03-09-1affd32f93b299d5a907816c328ca3ededb73a7e

@mkruskal-google
Copy link
Copy Markdown
Member

mkruskal-google commented Sep 29, 2022

protobuf doesn't depend on grpc, so there should be no reason we're causing an upgrade of it. It sounds like you have a more recent version of gRPC installed that depends on Abseil, but don't have Abseil installed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mkruskal-google mkruskal-google mkruskal-google approved these changes

+1 more reviewer

@Mizux Mizux Mizux left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

c++

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@acozzette @yoavmil @mkruskal-google @Mizux