expfmt: only call TextParser.TextToMetricFamilies once from textDecoder#443
Merged
roidelapluie merged 1 commit intoprometheus:mainfrom Feb 20, 2023
Merged
Conversation
Signed-off-by: Andy Bursavich <abursavich@gmail.com>
9e67cb1 to
5be97a0
Compare
beorn7
approved these changes
Feb 9, 2023
Member
beorn7
left a comment
There was a problem hiding this comment.
Thank you. I think this should work.
@roidelapluie I lease final approval/merge to you.
roidelapluie
approved these changes
Feb 20, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #442
It turns out that TextParser.TextToMetricFamilies reads all metrics the first time and only returns partial results if there's an error. The bug was triggered by calling it twice. We only need to call it once.