Make it more efficient and compatible to use SampleHistogram#439
Merged
codesome merged 5 commits intoprometheus:mainfrom Jan 26, 2023
Merged
Make it more efficient and compatible to use SampleHistogram#439codesome merged 5 commits intoprometheus:mainfrom
codesome merged 5 commits intoprometheus:mainfrom
Conversation
Store SampleHistogram in SampleHistogramPair as pointer. More compatible with what protobuf generates. More efficient when taking the histogram from the pair. Simpler test code. Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com>
codesome
reviewed
Jan 26, 2023
| type SampleHistogramPair struct { | ||
| Timestamp Time | ||
| Histogram SampleHistogram | ||
| Histogram *SampleHistogram |
Member
There was a problem hiding this comment.
Worth commenting that it should never be nil and it is as a pointer for efficiency.
Member
Author
There was a problem hiding this comment.
should MarshalJSON check that it's nil and error out if it is?
Member
Author
There was a problem hiding this comment.
I've ended up convincing myself to error on nil histogram, to avoid ever generating invalid JSON from this
Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com>
Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com>
Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com>
codesome
reviewed
Jan 26, 2023
Co-authored-by: Ganesh Vernekar <ganeshvern@gmail.com> Signed-off-by: George Krajcsovits <krajorama@users.noreply.github.com>
radek-ryckowski
pushed a commit
to goldmansachs/common
that referenced
this pull request
May 18, 2023
…eus#439) Store SampleHistogram in SampleHistogramPair as pointer. More compatible with what protobuf generates. More efficient when taking the histogram from the pair. Simpler test code. Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com> Signed-off-by: George Krajcsovits <krajorama@users.noreply.github.com> Co-authored-by: Ganesh Vernekar <ganeshvern@gmail.com>
radek-ryckowski
pushed a commit
to goldmansachs/common
that referenced
this pull request
May 21, 2025
…eus#439) Store SampleHistogram in SampleHistogramPair as pointer. More compatible with what protobuf generates. More efficient when taking the histogram from the pair. Simpler test code. Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com> Signed-off-by: George Krajcsovits <krajorama@users.noreply.github.com> Co-authored-by: Ganesh Vernekar <ganeshvern@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Store SampleHistogram in SampleHistogramPair as pointer.
More compatible with what protobuf generates.
More efficient when taking the histogram from the pair.
Simpler test code.
Signed-off-by: György Krajcsovits gyorgy.krajcsovits@grafana.com