Change HistogramBucket Boundaries type to int32#438
Merged
codesome merged 1 commit intoprometheus:mainfrom Jan 26, 2023
Merged
Conversation
Signed-off-by: Jeanette Tan <jeanette.tan@grafana.com>
c12ff73 to
0dd260f
Compare
codesome
approved these changes
Jan 26, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up to #417 . Made a mistake earlier, Boundaries is better as int32 for casting to/from compatible protobufs, as protobuf doesn't have int as a format, only int32. Better to correct this earlier to minimise the affected projects.