Skip to content

Adding Truncate methods to stringsutil#83

Merged
Mzack9999 merged 4 commits intoprojectdiscovery:mainfrom
AleFossa:main
Feb 12, 2023
Merged

Adding Truncate methods to stringsutil#83
Mzack9999 merged 4 commits intoprojectdiscovery:mainfrom
AleFossa:main

Conversation

@AleFossa
Copy link
Copy Markdown
Contributor

@AleFossa AleFossa commented Feb 12, 2023

Closes ##67

@ehsandeep ehsandeep linked an issue Feb 12, 2023 that may be closed by this pull request
Add Truncate method to stringsutil #67
Closed
@Mzack9999 Mzack9999 changed the title Closes #https://github.com/projectdiscovery/utils/issues/67 Adding Truncate methods to stringsutil Feb 12, 2023
@Mzack9999 Mzack9999 added the Type: Enhancement Most issues will probably ask for additions or changes. label Feb 12, 2023
@Mzack9999 Mzack9999 self-requested a review February 12, 2023 21:55
Mzack9999
Mzack9999 approved these changes Feb 12, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@Mzack9999 Mzack9999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm - Thanks for your PR @AleFossa. I made some minor changes, as also zero length is a valid case

@Mzack9999 Mzack9999 merged commit 1d3007f into projectdiscovery:main Feb 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Mzack9999 Mzack9999 Mzack9999 approved these changes

Assignees

No one assigned

Labels

Type: Enhancement Most issues will probably ask for additions or changes.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add Truncate method to stringsutil

2 participants

@AleFossa @Mzack9999