Skip to content

Add generic comparison helper function#91

Merged
Mzack9999 merged 6 commits intomainfrom
issue-90-equals-any-all
Feb 26, 2023
Merged

Add generic comparison helper function#91
Mzack9999 merged 6 commits intomainfrom
issue-90-equals-any-all

Conversation

@xm1k3
Copy link
Copy Markdown
Contributor

@xm1k3 xm1k3 commented Feb 24, 2023

func EqualsAll[T comparable](base T, all ...T) bool {}
func EqualsAny[T comparable](base T, all ...T) bool {}

@xm1k3 xm1k3 self-assigned this Feb 24, 2023
@xm1k3 xm1k3 added the Type: Enhancement Most issues will probably ask for additions or changes. label Feb 24, 2023
@xm1k3 xm1k3 linked an issue Feb 24, 2023 that may be closed by this pull request
@xm1k3 xm1k3 marked this pull request as ready for review February 24, 2023 19:04
@xm1k3 xm1k3 requested a review from tarunKoyalwar February 24, 2023 19:07
Copy link
Copy Markdown
Member

@tarunKoyalwar tarunKoyalwar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

func EqualsAll[T comparable](base T, all ...T) bool {}
func EqualsAny[T comparable](base T, all ...T) bool {}

both of the above functions should be in generic

@xm1k3 xm1k3 requested a review from tarunKoyalwar February 26, 2023 08:37
Copy link
Copy Markdown
Member

@tarunKoyalwar tarunKoyalwar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm !

@xm1k3 xm1k3 requested a review from Mzack9999 February 26, 2023 19:43
@Mzack9999 Mzack9999 merged commit b17bec2 into main Feb 26, 2023
@Mzack9999 Mzack9999 deleted the issue-90-equals-any-all branch February 26, 2023 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Type: Enhancement Most issues will probably ask for additions or changes.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add generic comparison helper function

3 participants