Skip to content

fix unsupported protocol scheme #49

Merged
Mzack9999 merged 1 commit intomainfrom
issue-unsupported-proto-scheme
Jan 23, 2023
Merged

fix unsupported protocol scheme #49
Mzack9999 merged 1 commit intomainfrom
issue-unsupported-proto-scheme

Conversation

@tarunKoyalwar
Copy link
Copy Markdown
Member

@tarunKoyalwar tarunKoyalwar commented Jan 23, 2023 •
edited
Loading

Proposed Changes

  • fix unsupported protocol scheme error ""
  • retyrablehttp-go does not always add scheme it only does if it will cause error
  • adds PreferHTTP switch to use http
  • adds testcases to unit test

closes #48

@tarunKoyalwar tarunKoyalwar self-assigned this Jan 23, 2023
Mzack9999
Mzack9999 requested changes Jan 23, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@Mzack9999 Mzack9999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggesting potential code snippet relocation to another package

Comment thread request.go
@Mzack9999 Mzack9999 merged commit 75b58f9 into main Jan 23, 2023
@Mzack9999 Mzack9999 deleted the issue-unsupported-proto-scheme branch January 23, 2023 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Mzack9999 Mzack9999 Mzack9999 approved these changes

Assignees

@tarunKoyalwar tarunKoyalwar

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

unsupported protocol scheme error with NewRequest

2 participants

@tarunKoyalwar @Mzack9999