Restore original request body in FromRequest function + Bump to go1.18#33
Merged
Restore original request body in FromRequest function + Bump to go1.18#33
Conversation
Member
|
Member
|
closes #30 Possible ExplainationEach unit test created a new web server (buggy http) on same port . but each of them ran on goroutines . |
Member
Changes
|
Member
|
Verified with projectdiscovery/nuclei#2924 . Works as expected !! |
Member
Author
|
Excellent work - It seems much more uniform and efficient now, additionally the underlying http.Transport won't be locked into I/O waiting operations. Not related to this PR, but I'd also like to add these changes related to the
|
Member
Author
|
lgtm - merging |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #32